Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js_separation branch: chart does not move in generated htmls #112

Closed
veghdev opened this issue Apr 11, 2022 · 1 comment
Closed

js_separation branch: chart does not move in generated htmls #112

veghdev opened this issue Apr 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@veghdev
Copy link
Member

veghdev commented Apr 11, 2022

With the new separated js class in the generated htmls the chart displayed after the first cell, and not moved (display="actual")
Even with manually saved ipynb output, even if nbconvert generated it.

Example:

cd tools/html-generator

with execute flag *if output not created and saved manually:
../../.venv/bin/jupyter nbconvert --Exporter.preprocessors=preprocessor.NbPreprocessor --to html --execute ../../docs/tutorial/sorting.ipynb

without execute flag *if output created and saved manually:
../../.venv/bin/jupyter nbconvert --Exporter.preprocessors=preprocessor.NbPreprocessor --to html ../../docs/tutorial/sorting.ipynb

@veghdev veghdev added the bug Something isn't working label Apr 11, 2022
@simzer
Copy link
Member

simzer commented Apr 11, 2022

This seems to be a bug in nbconvert. I have reported this issue: jupyter/nbconvert#1759

Meanwhile, we should switch back to generating divs with a unique id for ourselves for the time being.

@simzer simzer changed the title js_separation branch: chart does not move in gererated htmls js_separation branch: chart does not move in generated htmls Apr 11, 2022
@veghdev veghdev closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants