Skip to content

Commit

Permalink
fix clang-tidy
Browse files Browse the repository at this point in the history
  • Loading branch information
schaumb committed Jul 30, 2024
1 parent ccd8bc5 commit b9ab4ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
7 changes: 2 additions & 5 deletions src/chart/rendering/renderedchart.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ bool Marker::bounds(const CoordinateSystem &coordSys,
switch (shapeType) {
case Gen::ShapeType::rectangle:
case Gen::ShapeType::area:
return pointsToQuad(points, 0.1)
.contains(point, 0.01);
return pointsToQuad(0.1).contains(point, 0.01);
case Gen::ShapeType::circle:
return Geom::Circle(Geom::Rect::Boundary(points),
Geom::Circle::FromRect::sameWidth)
Expand All @@ -66,9 +65,7 @@ bool Marker::bounds(const CoordinateSystem &coordSys,
return isInside != false;
}

Geom::ConvexQuad Marker::pointsToQuad(
const std::array<Geom::Point, 4> &points,
double atLeastWidth) const
Geom::ConvexQuad Marker::pointsToQuad(double atLeastWidth) const
{
if (const auto &[p0, p1, p2, p3] = points;
p0 == p1 && p0 == p2 && p0 == p3) {
Expand Down
1 change: 0 additions & 1 deletion src/chart/rendering/renderedchart.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class Marker

private:
[[nodiscard]] Geom::ConvexQuad pointsToQuad(
const std::array<Geom::Point, 4> &points,
double atLeastWidthIfDot) const;

[[nodiscard]] Geom::ConvexQuad lineToQuad(
Expand Down

0 comments on commit b9ab4ae

Please sign in to comment.