Chart onChange and rendering connection moved to TS API #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When a resize happens, it needs to call Chart::doChange on the "ts" side. Would you like to change that in this PR? |
|
Checking size change inside wasm was obsolate, since size in wasm only got updated when needsUpdate was already queried. |
|
@schaumb No, on a second tought, i don't wan't to change the current size handling, because currently we force a redraw immediately if the canvas size changed. If we set the needsUpdate flag instead, it will only be redrawn when the next rendering scheduled, hance there migth be a visible delay on rendering refresh when we rescale the canvas. |
schaumb
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.