Skip to content

Commit

Permalink
Minor fix (#23)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vkatsuba
vkatsuba authored Jun 2, 2022
1 parent e338751 commit 802f2d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/rebar3_edoc_extensions_wrapper.erl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ run(#doclet_gen{app = App} = Cmd, #?RECORD{dir = Dir} = Ctxt) ->
Ctxt :: #?RECORD{},
Value :: any().
get_chained_mod(doclet, Options) when is_list(Options) ->
proplists:get_value(chained_doclet, Options);
proplists:get_value(chained_doclet, Options, edoc_doclet);
get_chained_mod(layout, Options) when is_list(Options) ->
proplists:get_value(chained_layout, Options);
proplists:get_value(chained_layout, Options, edoc_layout);
get_chained_mod(Option, Ctxt) when is_tuple(Ctxt) ->
#?RECORD{opts = Options} = Ctxt,
get_chained_mod(Option, Options).
Expand Down

7 comments on commit 802f2d2

@dumbbell
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert this change? There was no default set here on purpose to catch problems in the setup of the EDoc options.

@vkatsuba
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert this change? There was no default set here on purpose to catch problems in the setup of the EDoc options.

Yes this was done just for release.

@vkatsuba
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... still something wrong... I was revert changes - but still have same issue

@vkatsuba
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fixed...

@vkatsuba
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, user must set:

  {chained_doclet, edoc_doclet},
  {chained_layout, edoc_layout},

To edoc_opts config....

@vkatsuba
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that this is good idea. The plugin should works without additional config or required config. We can ass log stuff for case if value will be undefined

@vkatsuba
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look to proposal #24

Please sign in to comment.