-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side panel has a very small font and inconsistent mouse hover higlight area #1319
Comments
I cannot properly control the width of the buttons with the current settings, so the hover I cannot fix. The font cannot be any larger, or the text will be clipped. The only alternative is to remove the text label. The sidebar is actually a regular toolbar with some tweaks. The only way I can really fix this is to design a new widget for the purpose, which I may do. |
I think the issue I am facing has mostly to do with hidpi monitors maybe? I should have provided a screenshot to better illustrate the scaling disparity between the side (project) panel in comparison with the file menu: Unfortunately I am no longer able to test on Windows, like previously. This is on Linux so it may be that you are using a specific dependency to display icons that I am missing here...? |
You have no icons! Are you using a custom theme you made yourself? |
Ah, there was text below the screenshot as well. No, the icons should display fine. Unless you're using a theme you've made yourself, in which case you must update the theme definition file. It is covered in the documentation: https://novelwriter.readthedocs.io/en/stable/int_customise.html Edit: As for the font size, the button text is scaled to 65% of the GUI font size. This is to make it fit on the sidebar for the original English labels. It's up to the translators to make sure they fit for other languages. If I make it larger, it won't fit, so my option is to remove them, which is of course a possibility as well. |
Also, even if you are not loading an icon theme, a default one should be set. I fixed this in 2.0.1. Which version are you running? |
Note to self: Remove the labels in 2.1 and combine with feature request #1310. |
I don't think removing the labels completely would be good. I understand the decision now, it is reasonable as it is. No, no custom theme. The settings are as follows: If these icons are implemented in the same way as the dialog-box icons, they should work fine. This may be a regression between pre-2.0 and 2.0 releases somewhere possibly...? |
The Qt icons are loaded by the Qt library, and are different from the icons loaded specifically for novelwriter. It is strange that icons aren't loaded for you if you haven't made a copy of the theme file. Could you verify that you are running at least version 2.0.1, and that there are no errors or warnings written to the terminal when you start from command line? You can also run with the I would very much like to know what's going on here in case there's a bug. |
I am sending you the entire log, but you are probably interested in what theme.py is doing mostly... Here's a link: https://pastebin.com/KyWSKUv4
As for the version I am currently running, it's 2.0.3 |
Hmm, Aside from this, it looks like all the logic for loading icons on the Python side is there, and doing what it's supposed to. Also, the fix applied in the other thread where you were adding comments is included as you're running 2.0.3. That leaves the possibility that there is something missing in the Qt library related to SVG icons. It seems you are loading icons, but they are not processed into pixmaps (the null pixmap error), so all you get is blank icons with the correct dimensions. Qt ships the SVG library as a separate unit. I think there are some licensing issues there or something ... can't quite remember. How did you install novelWriter, and are you loading native Qt libraries, or installing them via pip? |
Not pip, running natively under Arch Linux. I have checked the build requirements according to https://github.com/vkbo/novelWriter/blob/main/requirements.txt and all are installed. |
Sorry for the late reply. I've been at a conference and travelled back yesterday. The requirements in the requirements file are the pip requirements. On pip, PyQt5 is complete. However, Qt5 consists of multiple components and libraries, and is not bundled into a single package on most distros. I know SVG is a separate linking when building with C++, and it may not be automatically installed on Arch when the rest is. For instance, on Debian it's a package called |
That's totally fine, this is just a side project after all, if an awesome one. Hope all went reasonably well at the conference.
Thank you for your patience, and above all, the very clear explanation. I have managed to find the dependency, it's a separate package called qt5-svg in Arch Linux that solves this issue. I'll notify the maintainer to update this as needed. |
It's good to get these things figured out. I'll make a note of this in the documentation as well. |
Signed-off-by: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com>
Signed-off-by: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com>
In the side-panel, the font seems way too small, even if they are meant to be smaller compared to other menu font sizes.
The text was updated successfully, but these errors were encountered: