Update build scripts #1829
Merged
Update build scripts #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried to update the AppImage and DMGs, and added build for ARM for MacOS. Could either of you test these, @Ryex and @mpejcoch? The builds are available here: https://github.com/vkbo/novelWriter/actions/runs/8766741231 |
|
Ok, @kkostov tested the M1 build, and apparently it just exits. |
|
There was an error in the launch script. I removed some escaping I shouldn't have. Should be fixed here: https://github.com/vkbo/novelWriter/actions/runs/8767345888 |
|
@vkbo confirmed, the fix worked and now the app works as well 🚀 
|
|
Great! Thanks for your help. |
|
Rosetta is a translation mechanism allowing x86_64 binaries to run on Apple Silicon. It's an optional component. macOS would only prompt the user to install it if they try to launch a binary which is not a Universal or Apple Silicon app. More info Unfortunately I can't remove Rosetta from my system as I need it for development purposes in order to really, really test. A quick check on the main binary of the app shows that it should be able to run without Rosetta: 
Is it possible that some internal libraries/dependencies/processes launched by the app are x86_64? I scanned the entire bin folder and all seem to be either scripts or arm64: for file in /Applications/novelWriter.app/Contents/Resources/bin/*; do
echo "$file:"
file "$file"
doneI also tried forcing the architecture using |
|
Thanks for testing. I think the issue may be somewhere in the lib folder rather than in bin. |
|
Seems it may be Qt5 actually. Also looks like Qt6 will be fine, so maybe the problem will solve itself when I switch novelWriter to Qt6. https://www.qt.io/blog/qt-on-apple-silicon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR:
Related Issue(s):
Reviewer's Checklist: