Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dialog handling #1844

Merged
merged 3 commits into from
May 1, 2024
Merged

Improve dialog handling #1844

merged 3 commits into from
May 1, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 1, 2024 •
edited
Loading

Summary:

This PR:

  • Adds dedicated subclasses for non-blocking modal dialogs, and non-modal tools dialog. This collects some common settings into custom classes.
  • Cleans up inheritance for the build tool dialogs.
  • Fixes a bug when deleting a build when its settings are open.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 Beta 1 milestone May 1, 2024
@vkbo vkbo merged commit 7180fae into main May 1, 2024
8 checks passed
@vkbo vkbo deleted the improvements/dialogs branch May 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.5 Beta 1
Development

Successfully merging this pull request may close these issues.
1 participant
@vkbo