Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project handling, cursor position, and Main GUI inheritance #1849

Merged
merged 4 commits into from
May 2, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 2, 2024

Summary:

This is a refactor/cleanup PR that restructures how various components interact with the Main GUI. Mostly through signals where possible. It also changes how document cursor position is saved. It is now saved even if the document is unchanged.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 Beta 1 milestone May 2, 2024
@vkbo vkbo merged commit c05620d into main May 2, 2024
8 checks passed
@vkbo vkbo deleted the improvements/project_tasks branch May 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant