Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dialogue highlighting #1864

Merged
merged 6 commits into from
May 13, 2024
Merged

Improve dialogue highlighting #1864

merged 6 commits into from
May 13, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 13, 2024

Summary:

This PR:

  • Splits dialogue highlighting from the selection of quote symbols.
  • Adds a setting to highlight dialogue as either "None", "Single Quotes", "Double Quotes" or "Both",
  • Adds a setting to allow open ended dialogue when highlighting.
  • Adds a setting for narrator break symbols (single character).
  • Adds a setting for opening characters for dialog lines (single character),
  • Adds two settings for custom, alternate dialog symbols (max 4 characters each).
  • Updates the syntax themes.

Related Issue(s):

Closes #1770 (allows two types of dialogue)
Closes #1771 (adds narrator break)

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 Beta 1 milestone May 13, 2024
@vkbo vkbo merged commit 4856c7a into main May 13, 2024
8 checks passed
@vkbo vkbo deleted the features/dialogue_highlight branch May 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support narrator break symbols and highlight rules Support custom amounts of quoting levels
1 participant