Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright #2154

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Update copyright #2154

merged 5 commits into from
Jan 3, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 3, 2025

Summary:

This PR updates the copyright notices in the source, but changes how they are expressed so this won't need to be done each year except for in the two license files included in Debian and Windows releases.

  • For source code files, only the year the file was created is used, if the code was new at the time.
  • If the code in the file was moved there, the year the class object was created is used instead.
  • There will no loner be a year range added, preventing the need for yearly updates.
  • Additional copyright entries are added for major contributions to the file by other people than the main author. For minor or trivial changes, this is not added.

These copyright statements are pretty much redundant, but they are useful meta data about the code's history. If there at some point are a lot of contributors to files, the names may be replaced with "and contributors". This is a non-issue at this time.

Only @bkmeneguello and @Ryex have been added to the list in a handful of files.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Repo Maintenance milestone Jan 3, 2025
@vkbo
Copy link
Owner Author

vkbo commented Jan 3, 2025

Decided to go with:

Copyright (C) 20xx Veronica Berglyd Olsen and novelWriter contributors

It avoids the issue of determining what is and isn't a significant contributions, and the contributors are already listed in both the CREDIT file and the About dialog.

@vkbo vkbo merged commit 97fc64f into main Jan 3, 2025
9 checks passed
@vkbo vkbo deleted the copyright branch January 3, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant