Fixes Windows issue where filebeats service is reinstalled on each run #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request fixes issue #134 . Instead of having the
powershell_script 'install filebeat as service'resource run every time, it only runs afterwindows_zipfilecompletes.Testing shows this fixes the problem of the Windows service being stopped/deleted on every chef-client run. I'm also able to perform version upgrades with this code.
One note, this cookbook is affected by the issues below where versions of filebeat 6.4.0 and later cannot be uncompressed with the windows_zipfile resource. I did not try to resolve that issue here, so specifying version 6.3.2 or earlier is needed to test.
chef-boneyard/windows#459
elastic/beats#9259