-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create strong named assembiles #543
Create strong named assembiles #543
Conversation
5b7b8ad
to
2c9e93e
Compare
2c9e93e
to
5d1d850
Compare
New project was added to create strong named assembiles. Signing key is included inside the project. The Dockerfile was updated to build the strong named assembly package. Azure pipelines were updated to publish nuget package as a GitHub asset and also to NuGet.org.
5d1d850
to
42d9354
Compare
New csproj is just a copy of the existing one. I suggest you to move common properties to Directory.Build.props |
Oh yeah, thanks mate. I knew something was amiss. |
I wonder though, wouldn't a |
1ee91e0
to
699d24f
Compare
699d24f
to
71f669c
Compare
I've gone with a |
Hey, any thoughts on the PR? |
Hey, sorry, really short on time these days. I'll test it during the upcoming weekend and will push it "to prod" if everything looks good (which it does on the first glance). |
The current approach looks good, no need to include the common proj into examples and tests, those aren't getting published anyway. Locally everything looks good, merged it to master, let's see how the build goes. |
Yeah, binaries stopped being published to GitHub awhile ago, this is the last release where it did get published: https://github.com/vkhorikov/CSharpFunctionalExtensions/releases/tag/v2.14.0 The new |
The pipeline has published the new nuget package successfully. |
Wow, that's awesome news. I'll start using it right away. |
Create strong named NuGet package
To create a strong named NuGet package, a new project
CSharpFunctionalExtensions.StrongName
was added to the solution.The project references source files from
CSharpFunctionalExtensions.csproj
and it uses the generated signing key (CSharpFunctionalExtensions.snk
) to sign the assembly.The
Dockerfile
was updated so that a strong named NuGet package is also built.The
azure-pipelines.yml
was also modified so that the newly created package is uploaded as both a GitHub release asset and to nuget.org as well.Minor fixes were applied to the
azure-pipelines.yml
file:Bearer
instead of token based on the documentationcURL
upload should use the--data-binary
switch (note that nuget packages were not added to previous releases either)The version file
version.txt
was also updated with a patch version bump.Fixes: #27