Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allocation-free Maybe.Bind overload #565

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

marcinjahn
Copy link
Contributor

@marcinjahn marcinjahn commented Sep 10, 2024

For now I've added just the Maybe.Bind overload in order for the approach to be validated.

  1. Is the naming OK? (context)?
  2. Is it OK that the logic is duplicated in allocating and non-allocating overloads? Is it possible to not duplicate the code?
  3. Are tests alright?

When the approach gets approved, I will be able to create overloads for other extensions.

This PR is the result of #562.

@vkhorikov
Copy link
Owner

Sorry for the later reply. Some extra empty lines aside, everything looks good to me. Merging.

@vkhorikov vkhorikov merged commit 9599a06 into vkhorikov:master Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants