Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle spaces in path only on Windows #40

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

vinocher-bc
Copy link
Contributor

Fixes #39

Handle spaces in path only on Windows to prevent breaking Linux and macOS, because only the Windows code path, which calls spawnSync with shell:true, needs this.

@tristanlabelle tristanlabelle requested a review from vknabel June 6, 2024 17:01
@tristanlabelle tristanlabelle merged commit d64f8f3 into vknabel:main Jun 6, 2024
1 check passed
@tristanlabelle
Copy link
Collaborator

@vknabel , what's the process for publishing a release? I see you added the workflow, do I just use "draft a new release" from here and replicate the format you used previously, and that will kick off the workflow?

@vknabel
Copy link
Owner

vknabel commented Jun 6, 2024

@tristanlabelle sorry for not describing yet.

  • bump the version in the package.json
  • Create a tag (vX.X.X)
  • Publish it as release in github
  • You can just autogenerate the release notes

Update: now mentioned in CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest release (v1.6.8) broke swiftformat path (macOS/Linux).
3 participants