Native Collection has not been disposed, resulting in a memory leak.

[NachtgeistW]

This happened in 2021.1. Every time I press "Play" button, they appear in console. I used com.unity.jobs and caught these:

A Native Collection has not been disposed, resulting in a memory leak. Allocated from:
Unity.Collections.NativeArray`1:.ctor(Byte[], Allocator)
UnityEngine.Networking.UploadHandlerRaw:.ctor(Byte[])
WakaTime.Plugin:SendHeartbeat(Boolean) (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:145)
WakaTime.Plugin:OnSceneClosing(Scene, Boolean) (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:205)
UnityEditor.SceneManagement.EditorSceneManager:Internal_SceneClosing(Scene, Boolean)

A Native Collection has not been disposed, resulting in a memory leak. Allocated from:
Unity.Collections.NativeArray`1:.ctor(Byte[], Allocator)
UnityEngine.Networking.UploadHandlerRaw:.ctor(Byte[])
WakaTime.Plugin:SendHeartbeat(Boolean) (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:145)
WakaTime.Plugin:Initialize() (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:62)
WakaTime.Plugin:OnScriptReload() (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:181)

A Native Collection has not been disposed, resulting in a memory leak. Allocated from:
Unity.Collections.NativeArray`1:.ctor(Byte[], Allocator)
UnityEngine.Networking.UploadHandlerRaw:.ctor(Byte[])
WakaTime.Plugin:SendHeartbeat(Boolean) (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:145)
WakaTime.Plugin:OnPlaymodeStateChanged(PlayModeStateChange) (at Library\PackageCache\com.vladfaust.unitywakatime@4dedbea\Editor\Plugin.cs:185)
UnityEditor.EditorApplication:Internal_PlayModeStateChanged(PlayModeStateChange)
UnityEditor.EditorApplication:set_isPlaying(Boolean)
Unity.Entities.Editor.LiveLinkToolbar:TogglePlaying() (at Library\PackageCache\com.unity.entities@0.17.0-preview.41\Unity.Entities.Editor\LiveLink\LiveLinkToolbar.cs:94)
Unity.Entities.Editor.LiveLinkToolbar:DrawPlaybar(CommandExecuteContext) (at Library\PackageCache\com.unity.entities@0.17.0-preview.41\Unity.Entities.Editor\LiveLink\LiveLinkToolbar.cs:60)
UnityEditor.CommandService:ExecuteCommand(String, CommandHint, Object[])
UnityEditor.CommandService:Execute(String, CommandHint, Object[])
UnityEditor.ModeService:Execute(String, CommandHint, Object[])
UnityEditor.ModeService:Execute(String, Object[])
UnityEditor.Toolbars.PlayModeButtons:OverrideGUIHandler()
UnityEngine.UIElements.IMGUIContainer:DoOnGUI(Event, Matrix4x4, Rect, Boolean, Rect, Action, Boolean)
UnityEngine.UIElements.IMGUIContainer:HandleIMGUIEvent(Event, Matrix4x4, Rect, Action, Boolean)
UnityEngine.UIElements.IMGUIContainer:HandleIMGUIEvent(Event, Action, Boolean)
UnityEngine.UIElements.IMGUIContainer:HandleIMGUIEvent(Event, Boolean)
UnityEngine.UIElements.IMGUIContainer:SendEventToIMGUIRaw(EventBase, Boolean, Boolean)
UnityEngine.UIElements.IMGUIContainer:SendEventToIMGUI(EventBase, Boolean, Boolean)
UnityEngine.UIElements.IMGUIContainer:HandleEvent(EventBase)
UnityEngine.UIElements.CallbackEventHandler:HandleEventAtTargetPhase(EventBase)
UnityEngine.UIElements.MouseCaptureDispatchingStrategy:DispatchEvent(EventBase, IPanel)
UnityEngine.UIElements.EventDispatcher:ApplyDispatchingStrategies(EventBase, IPanel, Boolean)
UnityEngine.UIElements.EventDispatcher:ProcessEvent(EventBase, IPanel)
UnityEngine.UIElements.EventDispatcher:ProcessEventQueue()
UnityEngine.UIElements.EventDispatcher:OpenGate()
UnityEngine.UIElements.EventDispatcherGate:Dispose()
UnityEngine.UIElements.EventDispatcher:ProcessEvent(EventBase, IPanel)
UnityEngine.UIElements.EventDispatcher:Dispatch(EventBase, IPanel, DispatchMode)
UnityEngine.UIElements.BaseVisualElementPanel:SendEvent(EventBase, DispatchMode)
UnityEngine.UIElements.UIElementsUtility:DoDispatch(BaseVisualElementPanel)
UnityEngine.UIElements.UIElementsUtility:UnityEngine.UIElements.IUIElementsUtility.ProcessEvent(Int32, IntPtr, Boolean&)
UnityEngine.UIElements.UIEventRegistration:ProcessEvent(Int32, IntPtr)
UnityEngine.UIElements.<>c:<.cctor>b__1_2(Int32, IntPtr)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

[hyperdotbat]

Same here, its leaking memory

[vladfaust]

I can guess that UploadHandlerRaw shall be disposed properly @

unity-wakatime/Assets/com.vladfaust.unitywakatime/Editor/Plugin.cs

Line 145 in 72a7845

request.uploadHandler = new UploadHandlerRaw(System.Text.Encoding.UTF8.GetBytes(heartbeatJSON));

[JayPeet]

I think the UnityWebRequest.Post needs to be wrapped in a using statement so that it disposes correctly have Dispose called manually in the completed callback.

I am pretty sure the native collection leak is something which only happens on more recent unity versions, as it is not a problem on pre 2021 versions from what I saw

I can go make a PR with fixes in if needed :)

[JayPeet]

PR is here: #31

[BrianLDev]

This bug is still happening and causing constant error messages in Unity. Can someone approve the PR that JayPeet created to fix this?

[vladfaust]

@BrianLDev

Actually, this sometimes still has the issue.

[BrianLDev]

Ah that's a shame. The error messages were getting annoying and I was hoping this would fix it.

[JayPeet]

Yeah, I need to investigate it properly still. Just been too busy :(

[vladfaust]

I'm not a Unity developer anymore. At least for now. Would be happy if someone takes over this repository. @Hermesiss?

[Hermesiss]

Yes, I'm still an active Unity developer. @vladfaust can you transfer this repo to me?

[vladfaust]

@Hermesiss let's begin with fixing this issue (you're a collaborator) 😃

[Hermesiss]

@JayPeet @NachtgeistW @HyperGamesDev Can you provide an example project? I can't reproduce this error

[hyperdotbat]

my repository SSS222 had WakaTime before, sorry for the inconvenience but you'd have to add it once again now as I removed it(also the Jobs addon). Not sure when it appeared though so it may be difficult to reproduce