add multiple entrypoint support - fixes #63 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoac
changed the title
cwoac
force-pushed
the
multiple_media_dirs
branch
from
eb30e70 to
cb93672
Compare
vladgh
reviewed
Jul 18, 2018
There was a problem hiding this comment.
Thank you for this PR. It's a very elegant solution to declaring multiple media_dirs. However, I would like to make a few changes. First, it would be best if the variable name stays in the MINIDLNA_ namespace (so that means for example MINIDLNA_MEDIA_DIR_1). In addition, nesting the IF will get rid of duplicate code. I'll try to change it.
|
Let me know what you think. |
|
That seems a perfectly fine way of doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you cannot specify the same environment variable multiple times, and minidnla requires each media directory to be passed as a separate parameter, I added another check for any environment variable starting with
MEDIA_DIR. This would resolve #63. Existing configs usingMINIDNLA_MEDIA_DIR=will still work as well.