Dev - enhancements and fixes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "." at the beginning of the ".init.lua" file name marks it as a hidden file in Linux and some sync programs. That can cause sync programs to not copy the file. Renaming to "!init.lua" resolves that problem, while still ensuring the script is loaded before any of the other completion scripts.
So, for best compatibility, clink-completions will have both .init.lua and !init.lua files.
This enables newer Clink versions to load and use completions scripts on demand, even in Cmder (which manually loads clink-completions scripts, so Clink doesn't know about their script directory).
Requires Clink v1.3.40 to work fully properly.
`git ls-files` doesn't have a linked argmatcher, so the `git` flags were bleeding into it. And etc for other commands.
It's very unusual to add or checkout unchanged files. So `git add` uses `git status -uall` to generate file matches. And `git checkout` uses `git status -uno` to generate file matches.
Return nothing, rather than returning an empty table. This makes it easier for a caller to recognize it's not supported.
- It uses new APIs when available. - It accepts a list of wildcards and adds them all at once, which makes adding directories much more efficient (only one time).
This colors the yarn run matches. In old Clink versions, it has no effect.
While improving `yarn run` completions, `yarn` completions lost the `run` matches. Also, apply color to yarn local module matches, to differentiate them from yarn commands.
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 54.16% 53.20% -0.97%
==========================================
Files 5 5
Lines 144 156 +12
==========================================
+ Hits 78 83 +5
- Misses 66 73 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several argmatchers, applies some enhancements, fixes some bugs, and cleans up luacheck warnings.