deployment tweaks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RBAC rules were already obsolete before and in 1.0.2 they were also removed officially (https://github.com/kubernetes-csi/node-driver-registrar/releases/tag/v1.0.2).
Picking the RBAC rules from a release branch is not quite accurate (we want the rules released together with the tagged version) and is something that must be kept in sync manually. It is better to not hard-code this in the script and instead get the exact versions from the .yaml files. There should be no need for users to pass parameters to the script, so let's just mention that this is possible without going into details in the README.md. The previous instructions were out-dated, too.
|
@pohly thanks for this piece of code. |
vladimirvivien
pushed a commit
that referenced
this pull request
Mar 13, 2019
Moves hostpath driver from kubernetes-csi/drivers monorepo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for the two issues that I raised during the initial review of kubernetes-csi#1: