Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page title #6

Closed
modem7 opened this issue Aug 12, 2024 · 3 comments
Closed

Page title #6

modem7 opened this issue Aug 12, 2024 · 3 comments

Comments

@modem7
Copy link

modem7 commented Aug 12, 2024

To make things appear neater, is it possible to add a page title for tabs?

Currently, it's just showing as ghstats.mydomain.com in the tab.

My thiking is:

Homepage: GHStats (or similar)
Repo: Repoowner/reponame

Low priority I know.

@101br03k
Copy link

101br03k commented Aug 12, 2024

Taking a quick look it seams that because there is no title set in src/main.rs it pickes the default wich in my case is the LAN IPv4 adres and port inluding the repowner and repo name with slashes.

Static should be easy to do, dynamic a little harder but not to hard since the var that sets the repo name in the page sould be able to put in there. Will try it localy but can't push it to gh because I already have a brance for #3 in order to order pr and issues / feature requests using github templates.

Also would like to point out there is no icon set. Will just set one in there, will just be the owner icon for now.
Also no rust for long time, this can take some time.

edit: typo's

vladkens added a commit that referenced this issue Aug 12, 2024
@vladkens
Copy link
Owner

@modem7 nice catch. I will include this into next release.

@vladkens
Copy link
Owner

Released in v0.3.0

@modem7 modem7 closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants