treesitter: correctly recognize shebang #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on the regression regarding reference types introduced in the recent upstream commit. |
what do you mean? |
Tests are failing here because of a change in vlang/v#21025. It's fixed in vlang/v#21030. I'll see to work out a test case |
|
Hm, I thought it was a pure refactoring, and the main CI tests passed. A test case will be much appreciated indeed. |
|
Thought so too. It slipped through. But if it gives us extended test coverage, it had its blessings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of how we we proceed with treating the shebangs in vlang/v#21029
Currently, a shebang is not correctly recognized by tree-sitter. It's not highlighted and can break the highlighting of identifiers that follow it.
This PR aims to fix this.
Current
Updated
