Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use .vv extension for meta- and testdata files #53

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 23, 2024

The files contain code that will encounter problems when running v fmt with some flags.
Updating the extension keeps them working while allowing to add a formatting verification to the projects CI workflows.

Thanks @spytheman. Ref.: vlang/v#21057 (comment)

@ttytm

This comment was marked as outdated.

@ttytm ttytm force-pushed the chore/use-vv-ext-for-meta-and-testdata-files branch from de042a6 to 721d138 Compare March 23, 2024 17:59
@ttytm ttytm marked this pull request as draft March 24, 2024 11:47
@ttytm ttytm force-pushed the chore/use-vv-ext-for-meta-and-testdata-files branch from 721d138 to a82c4a5 Compare March 24, 2024 12:34
@ttytm ttytm marked this pull request as ready for review March 24, 2024 12:41
@spytheman
Copy link
Member

There is a conflict in embed.v, otherwise it LGTM.

@ttytm ttytm force-pushed the chore/use-vv-ext-for-meta-and-testdata-files branch from a82c4a5 to 29902c5 Compare March 25, 2024 11:53
@ttytm ttytm merged commit 3c3b24a into vlang:main Mar 25, 2024
16 checks passed
@ttytm ttytm mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants