Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer] fix infer type of as expression #91

Closed
wants to merge 1 commit into from
Closed

[analyzer] fix infer type of as expression #91

wants to merge 1 commit into from

Conversation

Lycs-D
Copy link
Contributor

@Lycs-D Lycs-D commented Apr 10, 2024

No description provided.

Copy link
Member

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there isn't a linked issue, it would help to have a little description with a PR when it tries to fix something. This would simplify things for the reviewer and provide the potential to add a test for coverage. Also it would leave a reference and rationale in case merging a change like this comes with a regression.

@Lycs-D Lycs-D marked this pull request as draft April 11, 2024 02:14
@Lycs-D Lycs-D closed this by deleting the head repository Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants