-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
compiler: fix deprecation message for u8.
- Loading branch information
1 parent
510fb2a
commit d681e1c
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d681e1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? you say
u8
alias was removed, usebyte
instead' in commit 59ba551d681e1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove
u8
andi32
instead ofint
/byte
? This breaks consistency in naming of the basic data types as mentioned in #1718 .d681e1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this surprises me as well. I know @medvednikov prefers
int
, buti32
,u8
etc. are consistent and clear. And also fits well will "one way" principle. Withint
andbyte
the types are not named "one way" :)d681e1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This decision is not final yet, it'll be possible to easily switch to i32 and u8 with the help of vfmt.
To me personally []byte is more readable and clear than []u8 when used for bytes arrays (probably ~90% of cases).