Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C error on casting optional struct field #22960

Closed
gechandesu opened this issue Nov 24, 2024 · 1 comment · Fixed by #22973
Closed

C error on casting optional struct field #22960

gechandesu opened this issue Nov 24, 2024 · 1 comment · Fixed by #22973
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.

Comments

@gechandesu
Copy link
Contributor

gechandesu commented Nov 24, 2024

V doctor:

V full version: V 0.4.8 5ec9bb5.1345eac
OS: linux, Linux version 6.6.8-arch1-1 (linux@archlinux) (gcc (GCC) 13.2.1 20230801, GNU ld (GNU Binutils) 2.41.0) #1 SMP PREEMPT_DYNAMIC Thu, 21 Dec 2023 19:01:01 +0000
Processor: 16 cpus, 64bit, little endian, 12th Gen Intel(R) Core(TM) i5-1240P

getwd: /home/ge/Code/v/netaddr/issues
vexe: /home/ge/.vlang/v
vexe mtime: 2024-11-24 11:11:18

vroot: OK, value: /home/ge/.vlang
VMODULES: OK, value: /home/ge/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.46.1
Git vroot status: weekly.2024.47-25-g1345eac5
.git/config present: true

CC version: cc (GCC) 14.2.1 20240910
emcc version: N/A
thirdparty/tcc status: thirdparty-linux-amd64 0134e9b9

What did you do?
./v -g -o vdbg cmd/v && ./vdbg casting_optional_field_struct_method.vv

module main

struct Foo {
	foo string
	bar ?string
}

fn (f Foo) str() string {
	mut ret := f.foo
	bar_value := f.bar as string
	if bar_value == '' {
		return ret
	}
	return ret + '%' + bar_value
}

fn main() {
	ff := Foo{
		foo: 'Fooooo'
	}
	println(ff)
}

What did you expect to see?

'Fooooo' printed

What did you see instead?

================== C compilation error (from tcc): ==============
cc: /tmp/v_1000/casting_optional_field_struct_method.01JDEXY0DVN2RRQBB8CKSSYVTN.tmp.c:13719: error: '{' expected (got ";")
=================================================================
(You can pass `-cg`, or `-show-c-output` as well, to print all the C error messages).
builder error: 
==================
C error found. It should never happen, when compiling pure V code.
This is a V compiler bug, please report it using `v bug file.v`,
or goto https://github.com/vlang/v/issues/new/choose .
You can also use #help on Discord: https://discord.gg/vlang .

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21401

@Delta456
Copy link
Member

The below code is a workaround when #22953 gets merged. I will work on this after.

module main

struct Foo {
	foo string
	bar ?string
}

fn (f Foo) str() string {
	mut ret := f.foo
	v := f.bar
	bar_value := v as string
	if bar_value == '' {
		return ret
	}
	return ret + '%' + bar_value
}

fn main() {
	ff := Foo{
		foo: 'Fooooo'
	}
	println(ff)
}

@Delta456 Delta456 self-assigned this Nov 24, 2024
@Delta456 Delta456 added Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants