cgen: allow unwrapping of x as string expr
#22953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipensp
reviewed
Nov 24, 2024
felipensp
reviewed
Nov 24, 2024
…ath { sin, cos }`"
This reverts commit ddf0468.
spytheman
force-pushed
the
unwrap_option
branch
from
ca12cd5 to
fc72634
Compare
|
(rebased to resolve the merge conflict with master) |
felipensp
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Just noticed... imho it should go to vlib/v/tests/options/ folder.
There was a problem hiding this comment.
Good catch. I will PR this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22947
Huly®: V_0.6-21395