Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.parser: allow double quotes in @include template directives #20628

Merged
merged 4 commits into from
Feb 1, 2024
Merged

v.parser: allow double quotes in @include template directives #20628

merged 4 commits into from
Feb 1, 2024

Conversation

pierrec
Copy link
Contributor

@pierrec pierrec commented Jan 22, 2024

Fixes #16078.

@JalonSolov
Copy link
Contributor

Suggestion: cp cmd/tools/git_pre_commit_hook.vsh <your V clone>/.git/hooks/precommit

This installs a format check precommit hook, so that you will be blocked from committing changes that need to be formatted.

In the meantime, you need to run v fmt -w . in your repo and push the changed files.

@pierrec
v.parser: allow double quotes in @include template directives
ad2faac 
Fixes #16078.

Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
@pierrec
v.parser: v fmt -w
50916b8 
Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
@pierrec
v.parser: change to make autofree happy
67de5ab
spytheman
spytheman approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 232560d into vlang:master Feb 1, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$tmpl() - using double quotes instead of single for @include causes a V panic
3 participants
@pierrec @JalonSolov @spytheman