Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.http: Temporary fix intermittent segfault with http get text and gcc 13 2 [issue #20506] #20660

Merged
merged 2 commits into from
Jan 26, 2024
+2 −0
Merged

net.http: Temporary fix intermittent segfault with http get text and gcc 13 2 [issue #20506] #20660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4271de6
net.http: Temporary workaround for segfaults or nil values when compi…
GGRei Jan 26, 2024
66588e0
net.http: Updated comments to reflect the fix for intermittent segfau…
GGRei Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vlib/net/http/http.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ pub fn delete(url string) !Response {
return fetch(method: .delete, url: url)
}

// TODO - @[noinline] attribut is used for temporary fix the 'get_text()' intermittent segfault / nil value when compiling with GCC 13.2.x and -prod option ( Issue #20506 )
// fetch sends an HTTP request to the `url` with the given method and configuration.
@[noinline]
pub fn fetch(config FetchConfig) !Response {
if config.url == '' {
return error('http.fetch: empty url')
Expand Down
Loading