initial addition of AEAD ChaCha20Poly1305 algorithm in pure v #20817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following RFC is good. Is there an RFC mentioning the 2 nonce sizes? |
Its already in |
spytheman
reviewed
Feb 13, 2024
spytheman
reviewed
Feb 13, 2024
spytheman
reviewed
Feb 13, 2024
spytheman
reviewed
Feb 13, 2024
spytheman
reviewed
Feb 13, 2024
Co-authored-by: Delyan Angelov <delian66@gmail.com>
|
Thank for merging it ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the next step in two modules that have been merged into the experimental
x.cryptonamespace. This effort also adds to the completeness and capabilities of v crypto modules in the form of additional support for the authenticated encryption with additional data (AEAD) algorithm in pure V. See wiki about AEAD.In this pull request opportunity, I included the
AEADinterface which is actually more appropriate incrypto.cipher, but it doesn't matter where it is here, because this still needs review from the community and from experts. See the discussion on discord to find out his background and motivation.This module is mostly inspired by the Golang version and attempts to align and conform to the RFC 8439 standard ChaCha20 and Poly1305 for IETF Protocols, with a few additions, likes supports two nonce sizes, 12 bytes length of RFC 8439 and 24 bytes length of extended nonce size, wich is backed up by
x.crypto.chacha20which supports both sizes. For extended nonce size, see XChaCha for more detail.Please give a review, feedback or suggestion.
All are welcome
Thanks