Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chacha20: remove deprecated math.max_u32 in favour of builtin max_u32 #20838

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

blackshirt
Copy link
Contributor

@blackshirt blackshirt commented Feb 15, 2024

This small pull request fixs some spurious warning within x.crypto.chacha20 something related to deprecated constant from math.max_u32 with warning message :
warning: const `math.max_u32` has been deprecated since 2023-12-31, it will be an error after 2024-06-28; use built-in constant `max_u32` instead

Besides changing to the builtin max_u32, this pull request also includes some bits of cleaning and restructuring:

  • removes some bits of test data and move into core chacha_test.v file, and deletes test_data from repo.
  • removes unnecessary bits from common.v something related to poly1305 one-time key generation, its already built into this module.
  • moves some helper and core functions from common.v to the core chacha.v and delete common.v from repo.

Thanks

…u32`, bits of restructuring and removes unneceseary bits
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 9aeb822 into vlang:master Feb 15, 2024
42 checks passed
@blackshirt
Copy link
Contributor Author

Excellent work.

Thank you

@blackshirt blackshirt deleted the chacha20-cleanup branch February 15, 2024 04:59
@joe-conigliaro
Copy link
Member

Thanks @blackshirt

@blackshirt
Copy link
Contributor Author

Thanks @blackshirt

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants