chacha20: remove deprecated math.max_u32
in favour of builtin max_u32
#20838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small pull request fixs some spurious warning within
x.crypto.chacha20
something related to deprecated constant frommath.max_u32
with warning message :warning: const `math.max_u32` has been deprecated since 2023-12-31, it will be an error after 2024-06-28; use built-in constant `max_u32` instead
Besides changing to the builtin
max_u32
, this pull request also includes some bits of cleaning and restructuring:chacha_test.v
file, and deletestest_data
from repo.common.v
something related to poly1305 one-time key generation, its already built into this module.common.v
to the corechacha.v
and deletecommon.v
from repo.Thanks