Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix missing check for interface cast of option type #20961

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

felipensp
Copy link
Member

Fix missing interface cast checking

interface IFoo {
	a int
}

struct Foo {
	a int
}

fn main() {
	a := ?Foo{}
	dump(a)
	b := IFoo(a?)
	c := IFoo(a) // must be an error
}

@felipensp felipensp marked this pull request as ready for review March 4, 2024 18:56
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 115f83d into vlang:master Mar 4, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants