builtin: panic on trying to grow arrays with capacity bigger than 2^31, instead of overflowing a.cap (partial fix for #21918) #21947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits dynamic array capacity growth to max_int , and makes sure that a panic happens if that needs to be exceeded, instead of silently overflowing the .cap field (thus breaking the invariant about .len <= .cap).
It is a temporary workaround for #21918 , providing a better experience (allows for growing/processing till the actual limit, and a panic with a stacktrace, when the limit is reached, for improved debugging), until V transitions to using 64 bit numbers for the .len and .cap array fields.