Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: add a crypto.pbkdf2 module #22047

Merged
merged 7 commits into from
Aug 15, 2024
Merged

crypto: add a crypto.pbkdf2 module #22047

merged 7 commits into from
Aug 15, 2024

Conversation

sibkod
Copy link
Contributor

@sibkod sibkod commented Aug 15, 2024

Added pbkdf2

@Delta456
Copy link
Member

A reference to the original implementation and the need to explain why it has to be in vlib will also be helpful.

@spytheman spytheman changed the title Add pbkdf2 crypto: add a crypto.pbkdf2 module Aug 15, 2024
sibkod and others added 2 commits August 15, 2024 19:26
@sibkod @spytheman
Update vlib/crypto/pbkdf2/pbkdf2.v
f94a937 
Co-authored-by: Delyan Angelov <delian66@gmail.com>
@sibkod
pbkdf2 fmt
9d68003
@sibkod
Copy link
Contributor Author

sibkod commented Aug 15, 2024

A reference to the original implementation and the need to explain why it has to be in vlib will also be helpful.

Where should I specify a reference to the basic implementation?

@JalonSolov
Copy link
Contributor

Simplest would be in a comment block at the top of the pbkdf2.v file.

@spytheman spytheman merged commit eb314c9 into vlang:master Aug 15, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sibkod @Delta456 @JalonSolov @spytheman