Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: check duplicate interfaces when implements for struct #22230

Merged
merged 5 commits into from
Sep 17, 2024
Merged

checker: check duplicate interfaces when implements for struct #22230

merged 5 commits into from
Sep 17, 2024

Conversation

Delta456
Copy link
Member

This PR disallows duplicate interfaces when structs have explicit implements for interfaces.

@Krotki
Copy link
Contributor

Krotki commented Sep 15, 2024

What happens if you use walker.Visitor on top of tripe Visitor types in test ? Will recognize it as a same type ?

@Delta456
Copy link
Member Author

What happens if you use walker.Visitor on top of tripe Visitor types in test ? Will recognize it as a same type ?

It does recognise the same type. I have formatted the file so it truncated the explicit import symbol.

@spytheman spytheman merged commit 5f495e2 into vlang:master Sep 17, 2024
77 of 78 checks passed
@Delta456 Delta456 deleted the struct_implements branch September 17, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Delta456 @Krotki @spytheman