Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples,os: add an os.asset module, use it to simplify code in examples/, by removing $if android { checks #22281

Merged
merged 3 commits into from
Sep 22, 2024
Merged

examples,os: add an os.asset module, use it to simplify code in examples/, by removing $if android { checks #22281

merged 3 commits into from
Sep 22, 2024

Conversation

spytheman
Copy link
Member

No description provided.

larpon
larpon approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@larpon larpon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. I like how it simplifies code in userland ❤️

@spytheman
Copy link
Member Author

The CI failures are unrelated, and fixed on master.

@spytheman spytheman merged commit cfa91d8 into vlang:master Sep 22, 2024
70 of 73 checks passed
StunxFS
StunxFS reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@StunxFS StunxFS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💯

examples/clock/clock.v Show resolved Hide resolved
examples/fireworks/fireworks.v Show resolved Hide resolved
@spytheman spytheman deleted the add_os_asset_module branch September 22, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StunxFS StunxFS StunxFS left review comments

@larpon larpon larpon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spytheman @larpon @StunxFS