cgen: fix codegen for option sumtype with option variant #23656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-22076 |
spytheman
reviewed
Feb 5, 2025
| @@ -2585,7 +2585,7 @@ struct SumtypeCastingFn { | |||
|
|
|||
| fn (mut g Gen) get_sumtype_casting_fn(got_ ast.Type, exp_ ast.Type) string { | |||
| mut got, exp := got_.idx_type(), exp_.idx_type() | |||
| i := int(got) | int(u32(exp) << 17) | int(u32(exp_.has_flag(.option)) << 16) | |||
| i := int(got) | int(u32(exp) << 18) | int(u32(exp_.has_flag(.option)) << 17) | int(u32(got_.has_flag(.option)) << 16) | |||
There was a problem hiding this comment.
I think this should be better commented.
It took me 10 minutes to figure out what it actually does, and why the shifts are as they are.
There was a problem hiding this comment.
Given that we have:
vlib/v/gen/c/cgen.v:194:sumtype_definitions map[int]bool // `_TypeA_to_sumtype_TypeB()` fns that have been generated
can we just make the map map[u64]bool instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23653