Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v: fix compiler for -no-builtin #23724

Closed
wants to merge 1 commit into from

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Feb 14, 2025

Before this patch, building such code with -no-builtin was failing because GC code (that belongs to builtin)

a := [2]int{}

With the following code:

module main

import v.builder.nativebuilder

fn main() {
	nativebuilder.start()
}

Now it displays:
error: V builtin usage detected, but -no-builtin was supplied

Copy link

Connected to Huly®: V_0.6-22142

@spytheman
Copy link
Member

I am not sure that is better than the existing behavior, that at least produces something. The new error message is not specific (no position information), and it will trigger even for situations and code that could previously be compiled with -no-builtin. The native backend is still in development and imho it is reasonable to expect that people that are involved with it, can handle the resulting occasional panics during development better, than some non descriptive and non specific error message.

@spytheman spytheman closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants