Use a temporary folder in cd instead of manipulating a homepath folder #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tmp-folder is not yet created at this point. This should become part of the Makefile or something like that. Edit: @medvednikov wants to keep the Makefile clean and I agree with that. |
|
The tmp folder should be removed immediately after compilation. It should be created by the V compiler, not CC. |
|
This is not going to work once you go to a different directory to compile V files. |
yuyi98
pushed a commit
to yuyi98/v
that referenced
this pull request
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this also prompts a function in
osthat can recursively delete files in folders (and folders themselves)