Initial implementation of Serialize trait for Account #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasifaee
reviewed
May 6, 2024
ethereum_history_api/circuits/lib/src/account_with_storage_test.nr
Outdated
Show resolved
Hide resolved
Pasifaee
reviewed
May 8, 2024
|
|
||
| pub fn extend_back<LEN>(&mut self, other: [T; LEN]) { | ||
| for i in 0..LEN { | ||
| self.push_back(other[i]); |
There was a problem hiding this comment.
Beauty <3 love how our Fragment is growing up
Pasifaee
approved these changes
May 8, 2024
| } | ||
| } | ||
|
|
||
| global ACCOUNT_WITHIN_BLOCK_SERIALIZED_LEN = ACCOUNT_SERIALIZED_LEN + BYTES32_LENGTH; |
There was a problem hiding this comment.
Does it mean adding globals to use in generics now works?
There was a problem hiding this comment.
Yes. But arithmetic on generics still does not
marekkirejczyk
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to verify recursive proofs - we need to present our structure arguments as a field array.
This PR introduces the
Serializetrait & implements it onAccountWithinBlock,Account,U128andBytes32with tests.Noir has it planned, but it's not implemented yet: noir-lang/noir#3379