Storage fixtures #263
Merged
Storage fixtures #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajj999
approved these changes
May 9, 2024
| @@ -155,8 +155,7 @@ fn test_verify_header_invalid_receipt_root() { | |||
|
|
|||
| global RLP_SHORT_STRING_TYPE = 0x80; | |||
|
|
|||
| // TODO: Add correct assertion message when noir-trie-proofs is updated | |||
| #[test(should_fail)] | |||
| #[test(should_fail_with="Expected a list")] | |||
| data[i] = self[i] as Field; | ||
| } | ||
| data | ||
| self.map(|x: u8| x as Field) |
marekkirejczyk
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
mapwith explicit type declarations inSerializeimplementation as suggested in Expression type is ambiguous noir-lang/noir#4994 (comment)Fox context - before we used to take addresses, storage keys & storage values from proofs, but now our proofs use Fragments so they have those values padded and we need unpadded one in fixtures to make the code/tests easier