Migrate Account and Storage to merkle_patricia_proofs #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasifaee
force-pushed
the
iza/state_migration
branch
from
c55220b to
3f1a3e1
Compare
Pasifaee
force-pushed
the
iza/state_migration
branch
from
3f1a3e1 to
b758bae
Compare
LogvinovLeon
requested changes
May 27, 2024
|
|
||
| fn get_storage_value(rlp_encoded_value: [u8; MAX_STORAGE_VALUE_LEN]) -> [u8; MAX_STORAGE_VALUE_LEN] { | ||
| let mut storage_value = rlp_encoded_value; | ||
| let rlp_value_len = right_pad(rlp_encoded_value).len(); |
There was a problem hiding this comment.
I rewrote this function, now it uses Fragments and I think this name is outdated
ethereum/circuits/lib/src/receipt.nr
Outdated
| @@ -109,7 +110,7 @@ unconstrained fn get_receipt_unconstrained_M( | |||
| cumulative_gas_used: receipt.cumulative_gas_used, | |||
| logs_bloom: receipt.logs_bloom | |||
| }; | |||
| let proof_input = ProofInput::deserialize(proof_input); | |||
| let proof_input: ProofInput<MAX_PREFIXED_KEY_NIBBLE_LEN, MAX_VALUE_LEN_M, MAX_DEPTH_NO_LEAF, MAX_LEAF_LEN_M> = Serde::deserialize(proof_input); | |||
There was a problem hiding this comment.
Will it work without annotation?
There was a problem hiding this comment.
Oh, actually it works, I'll remove the annotations everywhere
| wrong_proof.proof[0] += 1; | ||
| let _ = verify_account(state_proof.key, account, wrong_proof, state_root); | ||
| let mut wrong_proof = state_proof_input; | ||
| wrong_proof.proof.nodes[0][0] -= 1; |
There was a problem hiding this comment.
Doing +1 instead of -1 causes a compiler panic
There was a problem hiding this comment.
Add a comment about RLP lel len issue and compiler panic
| wrong_address[0] += 1; | ||
| let _ = verify_account(wrong_address, account, state_proof, state_root); | ||
| let _ = verify_account(wrong_address, account, state_proof_input, state_root); | ||
| } | ||
|
|
||
| // TODO: Add correct assertion message when noir-trie-proofs is updated |
There was a problem hiding this comment.
Is this still a TODO? Seems like we don't even use noir-trie-proofs any more
There was a problem hiding this comment.
You're right, added correct assertion message
| wrong_proof.proof[0] += 1; | ||
| let _ = verify_account(state_proof.key, account, wrong_proof, state_root); | ||
| let mut wrong_proof = state_proof_input; | ||
| wrong_proof.proof.nodes[0][0] -= 1; |
There was a problem hiding this comment.
Add a comment about RLP lel len issue and compiler panic
Pasifaee
force-pushed
the
iza/state_migration
branch
from
f6d9081 to
fca07e1
Compare
akonior
reviewed
May 28, 2024
LogvinovLeon
approved these changes
May 28, 2024
Pasifaee
force-pushed
the
iza/state_migration
branch
from
4a4a730 to
221bc0a
Compare
akonior
approved these changes
May 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 29, 2024
This PR removes old proof fixtures as we don't use them anymore. It is a PR on top of #316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.