-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 - fix an issue where we would not converge in certain P2P scenarios #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db version gets set to max since we need to reord that there were changes ppl have never seen
tantaman
added a commit
that referenced
this pull request
Sep 5, 2023
🐛 - fix an issue where we would not converge in certain P2P scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switch from the vector clock to lamport clock design, we ended up conflating two concepts:
The original vector clock approach kept a version per column independent of the clock of the database.
When we merged the two ideas we created a situation where any time a merge changed a column value, we would set the clock of that column not to the winner's version but to
MAX(winner_version, crsql_nextdbversion())
This would cause a column to have its version number re-assigned.
Example:
merging
Q
toP
would put P in this state:Making id1,B look much newer than it ought to be.
which is ok (at least from a convergence perspective, maybe not user expectation perspective) in a client-server sync but not in p2p sync. This would cause state results to differ based on which peers sync with which first and require many rounds of messages to converge. When optimizing to "not sync self sourced changes" this can hit cases of non-convergence.