Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase vlingo-schemata integration #1

Merged
merged 12 commits into from
Dec 21, 2019
Merged

Conversation

wwerner
Copy link
Contributor

@wwerner wwerner commented Dec 8, 2019

@wwerner wwerner marked this pull request as ready for review December 13, 2019 12:37
Copy link
Contributor

@VaughnVernon VaughnVernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwerner 👍 I wish this could be less verbose, similar to the actorProxy entries. Is it possible?

@wwerner
Copy link
Contributor Author

wwerner commented Dec 19, 2019

I understand and find it too verbose as well.
However, I fould most alternatives too prescriptive:

  • Tie maven project version to the schema version - users can still do that using maven properties, but are not forced to
  • Parse the reference and version from the file name - feels brittle and too prescriptive

What we could do:

  • Let schemata figure out the previous version on the server side - this would benefit the UI as well and fit into the semantic versioning validation task
  • Make the source field optional and default to src/vlingo/schemata/<schema name from the reference>.vss.

In combination this would allow us to write

 <schemata>
   <schema>
     <ref>Vlingo:examples:schemata:SchemaDefined:0.0.1</ref>
     <!-- uses the default source file from the reference -->
   </schema>
   <schema>
     <ref>Vlingo:examples:schemata:SchemaPublished:0.0.1</ref>
     <src>some/other/weird/file.foo</src> <!-- but can be overridden -->
   </schema>
 </schemata>

I'd implement the second part now, then merge this PR and rework config and examples after the first part is implemented on the server side.
Ok?

See ⬇️ & vlingo/xoom-build-plugins#4

@VaughnVernon
Copy link
Contributor

VaughnVernon commented Dec 19, 2019

In combination this would allow us to write

 <schemata>
   <schema>
     <ref>Vlingo:examples:schemata:SchemaDefined:0.0.1</ref>
     <!-- uses the default source file from the reference -->
   </schema>
   <schema>
     <ref>Vlingo:examples:schemata:SchemaPublished:0.0.1</ref>
     <src>some/other/weird/file.foo</src> <!-- but can be overridden -->
   </schema>
 </schemata>

I'd implement the second part now, then merge this PR and rework config and examples after the first part is implemented on the server side.
Ok?

@wwerner Ok, good. Let's go with this. Thanks!

@wwerner wwerner merged commit d487947 into master Dec 21, 2019
@wwerner wwerner deleted the demo/schemata-integration branch December 21, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants