You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@wwerner My intention was for the typeVersion to be an int since io.vlingo.common.version. SemanticVersion understands how to convert into and out of multiple values of major, minor, and patch, as well as String representation. The int is only 4 bytes or less and as a JSON String-ified value most times 5-7 bytes (1.0.0 or 10.1.1, etc., and maybe 7 bytes as in 10.35.2).
Spec: version typeVersion
becomes: public final int typeVersion;
The above supports plain types, in case standard types not desired/used.
Further, if using a standard base class, spec should be: extends io.vlingo.lattice.model.DomainEvent extends io.vlingo.lattice.model.Command
public final class FooHappened extends DomainEvent {
// or
public final class DoFoo extends Command {
// nothing here for version because standard types have:
// public final int sourceTypeVersion;
// and also no occurredOn here because standard types have:
// public final long dateTimeSourced;
}
Sorry for the surprise extends. I have thought of how to deal with this but didn't finalize my ideas and this situation reminded me that it's necessary.
The text was updated successfully, but these errors were encountered:
Originally posted by @VaughnVernon in #98 (comment)
@wwerner My intention was for the
typeVersion
to be anint
sinceio.vlingo.common.version. SemanticVersion
understands how to convert into and out of multiple values ofmajor
,minor
, andpatch
, as well asString
representation. Theint
is only 4 bytes or less and as a JSONString
-ified value most times 5-7 bytes (1.0.0
or10.1.1
, etc., and maybe 7 bytes as in10.35.2
).Spec:
version typeVersion
becomes:
public final int typeVersion;
The above supports plain types, in case standard types not desired/used.
Further, if using a standard base class, spec should be:
extends io.vlingo.lattice.model.DomainEvent
extends io.vlingo.lattice.model.Command
becomes:
import io.vlingo.lattice.model.DomainEvent;
or:
import io.vlingo.lattice.model.Command;
Sorry for the surprise
extends
. I have thought of how to deal with this but didn't finalize my ideas and this situation reminded me that it's necessary.The text was updated successfully, but these errors were encountered: