Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freemarker based code generation #180

Merged
merged 9 commits into from
May 18, 2021
Merged

Freemarker based code generation #180

merged 9 commits into from
May 18, 2021

Conversation

hurelhuyag
Copy link
Contributor

No description provided.

@hurelhuyag hurelhuyag force-pushed the dev-freemarker-based-code-generation branch from bf92bdb to b2d360b Compare May 4, 2021 01:14
@hurelhuyag
freemarker based code generation
c60961a 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@hurelhuyag
JavaBackend replaced with CodeGenerator
d188d51 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@hurelhuyag
java DomainEvent.ftl improvement.
091fe22 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@hurelhuyag hurelhuyag force-pushed the dev-freemarker-based-code-generation branch from b2d360b to 091fe22 Compare May 14, 2021 05:44
@hurelhuyag
Copy link
Contributor Author

Java DomainEvent class generated passed all tests.

@hurelhuyag
CSharp DomainEvent.ftl
fd83752 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@hurelhuyag hurelhuyag marked this pull request as ready for review May 17, 2021 02:04
@hurelhuyag
CodeGenerator cleanup
627f988 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@hurelhuyag
DomainEventArguments namespace suffix event renamed to events
f9ffe2b 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
VaughnVernon
VaughnVernon approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@VaughnVernon VaughnVernon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hurelhuyag 👍

  • We must also support all other schema types:
    • Commands
    • Data
    • Documents
    • Envelopes
      Events

@hurelhuyag
Copy link
Contributor Author

hurelhuyag commented May 17, 2021 •
edited
Loading

  • Commands (similar to Events)
  • Data (Simple Java class)
  • Documents
  • Envelopes
  • Events

I have no idea what are documents and envelopes. @VaughnVernon, Can you show me some examples?

@VaughnVernon
Copy link
Contributor

They are defined identically but have a different type.

https://docs.vlingo.io/xoom-schemata#schema-version-specification-dsl

  • Event type uses Lattice base class DomainEvent
  • Command uses Lattice base class Command
  • All others have no base class

@hurelhuyag
codegen more type support
c9c1774 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
This was referenced May 17, 2021
Open
Closed
@VaughnVernon
Copy link
Contributor

@hurelhuyag this filename is no longer accurate because it supports multiple types (Event and Command, and others?):

src/main/resources/codegen/java/DomainEvent.ftl

@hurelhuyag
Copy link
Contributor Author

@VaughnVernon Yes. I'm thinking about the new name. Can you suggest a name?

@VaughnVernon
Copy link
Contributor

If it will support all types it could be named SchemaTypes.ftl.

@hurelhuyag
Copy link
Contributor Author

hurelhuyag commented May 17, 2021 •
edited
Loading

SchemaTypes.ftl

Not SchemaType.ftl?

@VaughnVernon
Copy link
Contributor

@hurelhuyag Sure that's fine. I was thinking plural since it's all types but singular is probably better.

@hurelhuyag
DomainEvent.ftl renamed to SchemaType.ftl
5dffcf1 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@hurelhuyag
DomainEventArguments.java renamed to SchemaTypeArguments
0c95486 
Signed-off-by: hurelhuyag <hurelhuyag@gmail.com>
@danilo-ambrosio danilo-ambrosio merged commit f7faea3 into master May 18, 2021
jakzal added a commit that referenced this pull request May 30, 2021
@jakzal
Revert "Merge pull request #180 from vlingo/dev-freemarker-based-code…
a6f6c02 
…-generation"

This reverts commit f7faea3, reversing
changes made to 0fe05e7.
@jakzal jakzal mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaughnVernon VaughnVernon VaughnVernon approved these changes

@danilo-ambrosio danilo-ambrosio danilo-ambrosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hurelhuyag @VaughnVernon @danilo-ambrosio