Skip to content

Conversation

@rtritto
Copy link
Contributor

@rtritto rtritto commented Mar 3, 2025

Close #154

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Additional Info

Example: plugin for Video.js https://github.com/mister-ben/videojs-mobile-ui

@vercel
Copy link

vercel bot commented Mar 3, 2025

@rtritto is attempting to deploy a commit to the Vlitejs Team on Vercel.

A member of the Team first needs to authorize it.

@rtritto rtritto changed the title Init mobile plugin Add Mobile plugin Mar 3, 2025
@rtritto
Copy link
Contributor Author

rtritto commented Mar 3, 2025

@phloxic sorry for the ping, are you interested to contribute to some point?

Points:

  • this mobile plugin
  • vLitejs player
  • other things

- [**Cast**](./src/plugins/cast/README.md) - Supports for Google Cast API.
- [**AirPlay**](./src/plugins/airplay/README.md) - Supports for Apple AirPlay API.
- [**Monetization**](./src/plugins/ima/README.md) - Supports for Google IMA SDK.
- [**Mobile**](./src/plugins/mobile/README.md) - Supports for mobile.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure for the plugin name. Can be confusing with the hotkey plugin?

Perhaps fastforward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin should be for devices (mobile, tablet etc) with touch events.

From videojs-mobile-ui:

Mobile UI for Video.js.

Touch controls:

  • Double-tap the left side of the player to rewind ten seconds
  • Double-tap the right side of the player to fast-forward ten seconds
  • Single-tap the screen to show a play/pause toggle

Fullscreen control:

  • Rotate to landscape to enter Fullscreen
  • Lock to fullscreen on rotate
  • Always lock to landscape when entering fullscreen (works even when device rotation is disabled/non-functional)

What features can/should we include in this plugin?

The plugin name depends on related feature/purpose/context.

}
}

.video-js.v-mobile-ui {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this class? There's no dependency between Vlitejs and Video.js, and I prefer it that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply copy-paste, the class needs to be rewritten/adapted

@yoriiis yoriiis closed this Apr 21, 2025
@rtritto rtritto mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin for Mobile

2 participants