-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add Mobile plugin #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mobile plugin #166
Conversation
|
@rtritto is attempting to deploy a commit to the Vlitejs Team on Vercel. A member of the Team first needs to authorize it. |
|
@phloxic sorry for the ping, are you interested to contribute to some point? Points:
|
| - [**Cast**](./src/plugins/cast/README.md) - Supports for Google Cast API. | ||
| - [**AirPlay**](./src/plugins/airplay/README.md) - Supports for Apple AirPlay API. | ||
| - [**Monetization**](./src/plugins/ima/README.md) - Supports for Google IMA SDK. | ||
| - [**Mobile**](./src/plugins/mobile/README.md) - Supports for mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure for the plugin name. Can be confusing with the hotkey plugin?
Perhaps fastforward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin should be for devices (mobile, tablet etc) with touch events.
From videojs-mobile-ui:
Mobile UI for Video.js.
Touch controls:
- Double-tap the left side of the player to rewind ten seconds
- Double-tap the right side of the player to fast-forward ten seconds
- Single-tap the screen to show a play/pause toggle
Fullscreen control:
- Rotate to landscape to enter Fullscreen
- Lock to fullscreen on rotate
- Always lock to landscape when entering fullscreen (works even when device rotation is disabled/non-functional)
What features can/should we include in this plugin?
The plugin name depends on related feature/purpose/context.
| } | ||
| } | ||
|
|
||
| .video-js.v-mobile-ui { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this class? There's no dependency between Vlitejs and Video.js, and I prefer it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply copy-paste, the class needs to be rewritten/adapted
Close #154
This PR contains a:
Additional Info
Example: plugin for Video.js https://github.com/mister-ben/videojs-mobile-ui