Skip to content

[BugFix] Potential ima fix #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

[BugFix] Potential ima fix #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions hopper/flash_fwd_combine_kernel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ class FlashAttnFwdCombine {

switch (choose_scheduling_algo(args)) {
case SchedulingAlgo::STANDARD: {
unsigned int num_blocks_k = cute::ceil_div(args.dv, kBlockK);
unsigned int num_blocks_m = cute::ceil_div(args.seqlen_q * args.num_heads, kBlockM);
return {num_blocks_m, num_blocks_k, static_cast<unsigned int>(args.b)};
}
Expand Down Expand Up @@ -426,15 +425,13 @@ class FlashAttnFwdCombine {
*params.semaphore_to_reset = 0;
}

if (batch >= params.b) { return; }
flash::SeqlenInfo<Varlen, kBlockM> seqlen_info{batch, size<0>(params.shape_LSE_partial), params.cu_seqlens, params.seqused};
int const offset = seqlen_info.offset;
int const seqlen = seqlen_info.seqlen;
int max_idx = seqlen * get<2>(params.shape_LSE_partial);

bool block_coord_valid =
block_coord.block_m < cute::ceil_div(max_idx, Int<kBlockM>{}) &&
block_coord.bidb < params.b;
if (!block_coord_valid) { return; }
if (m_block >= cute::ceil_div(max_idx, Int<kBlockM>{})) { return; }

int const num_splits = params.num_splits_dynamic_ptr ? params.num_splits_dynamic_ptr[batch] : get<1>(params.shape_LSE_partial);
if (num_splits <= 1) { return; }
Expand Down
Loading