metrics #104
Merged
metrics #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horheynm
force-pushed
the
metric-logger-fix
branch
5 times, most recently
from
ebab4c5 to
c57f891
Compare
Satrat
approved these changes
Aug 23, 2024
rahul-tuli
approved these changes
Aug 23, 2024
|
LGTM, could you add a PR description too please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Pytest goes thru the repo twice , once for capturing/generating fixtures the tests and the second for running.
Fixed bug where if levels of loguru were already set, skip. Collision happened when second iteration happened
TEST PLAN:
pass pytest