Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/duplicated/non-applicable utils from pytorch/utils/helpers #1174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Feb 19, 2025

Purpose

  • Remove utils, scoped to mostly src/llmcompressor/pytorch/utils/helpers.py
  • Remove any utils which are related to fine tuning and therefore non-applicable
  • Remove any utils which are duplicated by other utils files
  • Keep any utils that may be worth using in the future

Changes

  • Remove any unused/duplicated/non-applicable from pytorch/utils/helpers
  • Keep any utils that may be worth using in the future
  • Add pytest.mark.unit to helpers unit tests

Testing

  • grep -r "from llmcompressor.pytorch.utils" src/ tests/ examples/
  • Automated test coverage

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs marked this pull request as draft February 19, 2025 16:35
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs marked this pull request as ready for review February 19, 2025 16:50
@kylesayrs kylesayrs self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant