fix build error for nightly #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
dsikka
reviewed
Sep 6, 2024
yep, manually verified and it works for nightly and release. |
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
* fake quant fix * fix * comment * commetn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
To fix following error:
$ make build
python3 setup.py sdist bdist_wheel
Extracting version info from /home/dhuang/llm-compressor/src/llmcompressor
Traceback (most recent call last):
File "/home/dhuang/llm-compressor/setup.py", line 13, in
version_info = extract_version_info(package_path)
File "/home/dhuang/llm-compressor/utils/version_extractor.py", line 38, in extract_version_info
exec(open(version_path).read(), globals(), locals_dict)
File "", line 39, in
File "", line 25, in _generate_version_attributes
NameError: name 'datetime' is not defined
make: *** [Makefile:38: build] Error 1
TEST PLAN:
workflow to automate nightly build