fix package name bug for nightly #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuangnm
requested review from
markurtz,
dsikka,
rahul-tuli and
robertgshaw2-redhat
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
|
Will the name be updated by a bash script from another action? |
Correct, the workflow will change the setting build_type in src/llmcompressor/version.py to nightly/release/dev based on run type. |
dsikka
approved these changes
Sep 10, 2024
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
* add workflow to build and test * fix indent * clean up * add project id * minor update * fix a bug * test release * add test * fix test reporting issue * add upload and use compressed-tensors bucket * use secret for bucket * not install * still uses k8s-util * clean up * try GCP_GHA_SA * fix path * use NM_PYPI_SA again * authenticate with GCP_GHA_SA and NM_PYPI_SA * fix id * seperate install and test steps * test more configs * fix error * fix a bug * fix again * add step-status * fix failure * test release * clean up * clean up * update * test nightly * test release * fix a bug * fix a bug * change default back to NIGHTLY * clean up --------- Co-authored-by: dhuangnm <dhuang@MacBook-Pro-2.local> Co-authored-by: dhuangnm <dhuang@Rogers-iPhone.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
fix package name bug for nightly where nightly wheel still uses "llmcompressor" instead of "llmcompressor-nightly".
TEST PLAN:
manually tested for nightly, release and dev builds